feat: expose async wrap providers under async_hooks module #40760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
RafaelGSS
commented
Nov 8, 2021
mcollina
reviewed
Nov 8, 2021
targos
reviewed
Nov 8, 2021
targos
reviewed
Nov 9, 2021
doc/api/async_hooks.md
Outdated
| added: REPLACEME | ||
| --> | ||
| * Returns: A list of providers supported by async wrap. |
There was a problem hiding this comment.
Do we define anywhere what a "provider" is?
Also, to me "A list" means an array, but an object is returned.
There was a problem hiding this comment.
I think that it wasn't defined, at least publically. I can reword that for sure, but, to be honest, I don't know how to define the providers description.
There was a problem hiding this comment.
Suggested change
| * Returns: A list of providers supported by async wrap. | |
| * Returns: A map of provider types supported by async wrap. |
I would also add something to the description linking it to type parameter of the init(...) hook.
There was a problem hiding this comment.
Just did, thanks for point that out!
simoneb
reviewed
Nov 11, 2021
targos
reviewed
Nov 11, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Flarna
approved these changes
Nov 11, 2021
| * Returns: A map of provider types to the corresponding numeric id. | ||
| This map contains all the event types that might be emitted by the `async_hooks.init()` event. | ||
| This feature suppresses the deprecated usage of `process.binding('async_wrap').Providers`. |
|
Nit: My understaning of the commit message guideline tells that the commit message should start with |
|
I would just squash it all before merging and give it the async_hooks subsystem prefix then. |
35 tasks
RafaelGSS
force-pushed
the
feat/expose-async-wrap-providers
branch
from
f95a743 to
29ad912
Compare
docs: add asyncWrapProviders api doc tests(async_hooks): use internalBinding for comparisson fix(test-async-wrap): lint error docs: use REPLACEME for asyncWrapProviders update: use freeze and copy for asyncWrapProviders update(async_hooks): use primordials on asyncWrapProviders fix: use common to expect error docs(asyncWrapProviders): rephrase return type fix: lint md fix: lint md docs(async_hooks): typo Co-authored-by: Stephen Belanger <[email protected]> update(asyncWrapProviders): add __proto__ as null Co-authored-by: Simone Busoli <[email protected]> Co-authored-by: Michaël Zasso <[email protected]> test: adjust __proto__ assertion docs: add DEP0111 link
RafaelGSS
force-pushed
the
feat/expose-async-wrap-providers
branch
from
29ad912 to
c19f6e2
Compare
Qard
approved these changes
Nov 12, 2021
This was referenced Nov 13, 2021
This was referenced Nov 16, 2021
targos
added
the
semver-minor
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: #40730.